[ 
https://issues.apache.org/jira/browse/LUCENE-3526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134205#comment-13134205
 ] 

Michael McCandless commented on LUCENE-3526:
--------------------------------------------

I think the hack is actually correct, but maybe change it to check 
termEnum.position >= 0?

So this was a case we missed from LUCENE-3183 (maybe there are more!?), where 
we decided for the corner case of empty field and term text, the caller must 
handle that the returned enum is unpositioned (in exchange for not adding an if 
per next).

And maybe add the same comment about LUCENE-3183 on top of that logic?
                
> preflex codec returns wrong terms if you use an empty field name
> ----------------------------------------------------------------
>
>                 Key: LUCENE-3526
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3526
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-3526.patch, LUCENE-3526_test.patch, 
> LUCENE-3526_test.patch, LUCENE-3526_test.patch, LUCENE-3526_test.patch
>
>
> spinoff from LUCENE-3473.
> I have a standalone test for this... the termsenum is returning a bogus extra 
> empty-term (I assume it has no postings, i didnt try).
> This causes the checkindex test in LUCENE-3473 to fail, because there are 4 
> terms instead of 3. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to