[ 
https://issues.apache.org/jira/browse/LUCENE-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134247#comment-13134247
 ] 

Uwe Schindler commented on LUCENE-3473:
---------------------------------------

Robert: In your patch is an additional test for CheckIndex on the old indexes. 
This is implicitely already done by: testSearchOldIndex, which calls Testutil's 
checkindex as first step. So this test is duplicate and slows down, right?
                
> CheckIndex should verify numUniqueTerms == recomputedNumUniqueTerms
> -------------------------------------------------------------------
>
>                 Key: LUCENE-3473
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3473
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 3.4, 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-3473.patch, LUCENE-3473.patch, LUCENE-3473.patch
>
>
> Just glancing at the code it seems to sorta do this check, but only in the 
> hasOrd==true case maybe (which seems to be testing something else)?
> It would be nice to verify this also for terms dicts that dont support ord.
> we should add explicit checks per-field in 4.x, and for-all-fields in 3.x and 
> preflex

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to