[ 
https://issues.apache.org/jira/browse/LUCENE-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135179#comment-13135179
 ] 

Michael McCandless commented on LUCENE-3506:
--------------------------------------------

{quote}
Actually today when you run the tests - with assertions, without assertions, - 
you get no failures at all - which is what I was trying to fix here (unless I 
missed something seriously) - because:

* the original tests, after deciding to fail, invoked fail()
* this threw AssertionError
* but it was ignored as part of their wrong logic.
{quote}

Ahh, OK, I missed that fail() throws AssertionError which this then caught & 
ignored.  OK.  Patch looks good!
                
> tests for verifying that assertions are enabled do nothing since they ignore 
> AssertionError
> -------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3506
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3506
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: general/test
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>         Attachments: LUCENE-3506.patch, LUCENE-3506.patch
>
>
> Follow-up from LUCENE-3501

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to