[ 
https://issues.apache.org/jira/browse/LUCENE-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-2191:
--------------------------------

    Attachment: LUCENE-2191.patch

patch for trunk, just doing a rename
                
> rename Tokenizer.reset(Reader) to Tokenizer.setReader(Reader)
> -------------------------------------------------------------
>
>                 Key: LUCENE-2191
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2191
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/analysis
>            Reporter: Robert Muir
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-2191.patch
>
>
> in TokenStream there is a reset() method, but the method in Tokenizer used to 
> set a new Reader is called reset(Reader).
> in my opinion this name overloading creates a lot of confusion, and we see 
> things like reset(Reader) calling reset() even in StandardTokenizer...
> So I think this would be some work to fulfill all the backwards 
> compatibility, but worth it because when you look at the existing 
> reset(Reader) and reset() code in various tokenizers, or the javadocs for 
> Tokenizer, its pretty confusing and inconsistent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to