[
https://issues.apache.org/jira/browse/LUCENE-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145047#comment-13145047
]
Doron Cohen commented on LUCENE-3454:
-------------------------------------
bq. Perhaps I am the only one, but I find these ifNeeded, mabyeThis, mabyeThat
method names so ugly. I prefer JavaDoc for trying to catch the subtleties.
I feel that way too.
But a name change here seems in place, because as pointed above, there is an
issue with current catchy name *optimize()*.
My personal preference between the names suggested above is Mike's last one:
*forceMerge(int)*:
- it describes what's done
- does not suggest to do wonders
- requires caller to think twice because of deciding to force a certain behavior
> rename optimize to a less cool-sounding name
> --------------------------------------------
>
> Key: LUCENE-3454
> URL: https://issues.apache.org/jira/browse/LUCENE-3454
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 3.4, 4.0
> Reporter: Robert Muir
> Assignee: Michael McCandless
> Attachments: LUCENE-3454.patch
>
>
> I think users see the name optimize and feel they must do this, because who
> wants a suboptimal system? but this probably just results in wasted time and
> resources.
> maybe rename to collapseSegments or something?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
