[
https://issues.apache.org/jira/browse/LUCENE-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-3443:
--------------------------------
Attachment: LUCENE-3443.patch
I like this patch (it makes the fieldcache less confusing to me, currently I
only understand the 3.x one).
I updated the patch with a tiny optimization, maybe it can help resolve some
concerns. I see that solr defaults its "string" field etc to sortMissingLast.
I think its very common that many fields are populated for every document (of
course this option is totally stupid in this case...), but regardless of stupid
configurations we shouldn't do any additional pass there:
{code}
// if the field is fully populated, don't bother enumerating
if (terms.getDocCount() == maxDoc) {
return new Bits.MatchAllBits(maxDoc);
}
{code}
> Port 3.x FieldCache.getDocsWithField() to trunk
> -----------------------------------------------
>
> Key: LUCENE-3443
> URL: https://issues.apache.org/jira/browse/LUCENE-3443
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/search
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3443.patch, LUCENE-3443.patch
>
>
> [Spinoff from LUCENE-3390]
> I think the approach in 3.x for handling un-valued docs, and making it
> possible to specify how such docs are sorted, is better than the
> solution we have in trunk.
> I like that FC has a dedicated method to get the Bits for docs with field
> -- easy for apps to directly use. And I like that the
> bits have their own entry in the FC.
> One downside is that it's 2 passes to get values and valid bits, but
> I think we can fix this by passing optional bool to FC.getXXX methods
> indicating you want the bits, and the populate the FC entry for the
> missing bits as well. (We can do that for 3.x and trunk). Then it's
> single pass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
