[ 
https://issues.apache.org/jira/browse/SOLR-2888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dawid Weiss updated SOLR-2888:
------------------------------

    Attachment: SOLR-2888.patch

Proposed patch that fixes SOLR-2888 and SOLR-2887. This is also non-backwards 
compatible API refactoring -- FSTLookup has been split into FSTCompletion (not 
a Lookup subclass), there is an adapter for Lookup called FSTCompletionLookup.

These changes try to separate FSTCompletion from strings/floats used in Lookup. 
An external sorting on disk has been added. I tested it locally with 40m terms 
from Wikipedia -- FST construction was a memory bottleneck, everything else 
nicely spills to disk. Increasing RAM to ~1.5G did construct the suggester 
automaton for those 40m terms though.

Not everything done -- still some TODOs and ideas. Feel free to reiterate/ 
provide feedback.
                
> FSTSuggester should use utf8/utf32 order 
> -----------------------------------------
>
>                 Key: SOLR-2888
>                 URL: https://issues.apache.org/jira/browse/SOLR-2888
>             Project: Solr
>          Issue Type: Improvement
>          Components: spellchecker
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>             Fix For: 4.0
>
>         Attachments: SOLR-2888.patch
>
>
> For some reason it uses utf16 internally. Shouldn't make much of a 
> difference, really.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to