[
https://issues.apache.org/jira/browse/SOLR-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153288#comment-13153288
]
Shawn Heisey commented on SOLR-2906:
------------------------------------
bq. But really, it seems like you should disregard all the algorithmic stuff in
LRU when implementing LFU. If you think you see a bug in the existing LRU
stuff, you're going to have to spell it out for me a bit more.
I can't actually say that there is a bug, but I have to say that I'm really
confused (in the LRU code) by what lastAccessed(Copy) actually is and how it
works, and what the following code pieces from markAndSweep are doing with it,
since wantToKeep and wantToRemove are entry counts:
{code}
long thisEntry = ce.lastAccessedCopy;
<snip>
if (thisEntry > newestEntry - wantToKeep) {
<snip>
} else if (thisEntry < oldestEntry + wantToRemove) { // entry in bottom group?
{code}
> Implement LFU Cache
> -------------------
>
> Key: SOLR-2906
> URL: https://issues.apache.org/jira/browse/SOLR-2906
> Project: Solr
> Issue Type: Sub-task
> Components: search
> Affects Versions: 3.4
> Reporter: Shawn Heisey
> Priority: Minor
> Attachments: ConcurrentLFUCache.java, FastLFUCache.java
>
>
> Implement an LFU (Least Frequently Used) cache as the first step towards a
> full ARC cache
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
