[ 
https://issues.apache.org/jira/browse/LUCENE-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156003#comment-13156003
 ] 

Hoss Man commented on LUCENE-3587:
----------------------------------

rmuir: I'm not sure where/how you got the impression that anything about the 
release process should change.  If someone intended that, they should have said 
so yes/no?

Personally i'd prefer my patch to sarowe's, because then the generated javadocs 
don't change depending on if/when the oracle URL is up.  In general I disagree 
with sarowe's comment that ignoring the warning would mean we "attempt to do 
the right thing" -- because that implies that linking to the oracle.com URL is 
"the right thing" ... i think we should move away from that thinking.  In my 
opinion "the right thing" is to build our own docs and not make assumptions 
about external docs.  If the end user wants to build docs that hyperlink to 
oracle.com (or my.company.com/javadocs) that can be their choice, and if the 
URL is down and the linkage fails then the build.xml should fail to generate 
the docs because it couldn't do what the user asked it to.

but honestly: either patch is better then what we've got now.
                
> Attempting to link to Java SE JavaDocs is competely unreliable
> --------------------------------------------------------------
>
>                 Key: LUCENE-3587
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3587
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Hoss Man
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3587.3x.patch, 
> LUCENE-3587.keep-javadoc-link.3x.patch, 
> LUCENE-3587.keep-javadoc-link.trunk.patch, LUCENE-3587.trunk.patch
>
>
> As noted several times since Oracle bought Sun, the canonical links to the 
> Java SE JavaDocs have been unreliable and frequently cause warnings.
> Since we choose to fail the build on javadoc warnings, this is a serious 
> problem for anyone trying to build from source if/when the package-list we 
> reference in our common-build.xml is not available. 
> We should eliminate this dependency.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to