[ 
https://issues.apache.org/jira/browse/LUCENE-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167313#comment-13167313
 ] 

Robert Muir commented on LUCENE-3640:
-------------------------------------

Should not have been marked for 3.6... in 3.6 you can still open an 
IndexSearcher over a Directory and it manages the Reader instance in that case 
(so you should call close).

I started trying to backport test fixes, but i found 3.x's tests are massively 
out of sync with trunk, mostly using tons of deprecated APIs. I'll try to see 
if i can sync up the tests a bit, otherwise backporting in general is going to 
get difficult.
                
> remove IndexSearcher.close
> --------------------------
>
>                 Key: LUCENE-3640
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3640
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.0
>
>         Attachments: LUCENE-3640.patch, LUCENE-3640.patch
>
>
> Now that IS is never "heavy" (since you have to pass in your own IR), 
> IS.close is truly a no-op... I think we should remove it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to