[
https://issues.apache.org/jira/browse/SOLR-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-2971:
---------------------------------
Attachment: SOLR-2971.patch
SOLR-2971-3x.patch
I think these patches may be ready to apply. The only thing that makes me at
all nervous is the magic of calling deleteCore in the tests. The 3x tests
consistently failed without it, but trunk worked just fine. So I put the call
in both.
Sorry, there's a bit of gratuitous formatting in there, but it's pretty much
whitespace only....
Of course the 3x tests were enough different than the 4x ones that it needed a
different patch. Siiigggh. The actual core code changes are identical though.
For an issue this small, is there any reason to add anything to CHANGES.txt?
> ExternalFileFields fail if valType='float', and valType should be optional
> --------------------------------------------------------------------------
>
> Key: SOLR-2971
> URL: https://issues.apache.org/jira/browse/SOLR-2971
> Project: Solr
> Issue Type: Improvement
> Components: Schema and Analysis
> Affects Versions: 3.5, 4.0
> Environment: all
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-2971-3x.patch, SOLR-2971.patch, SOLR-2971.patch
>
>
> valType has never done anything except throw an error, the underlying
> ValueSource has always been a FileFloatSource. To add to the confusion, the
> documents say use "float", which throws an exception on Solr startup every
> since "float" was re-defined as a TrieFloatField. "pfloat" works currently
> though.
> Since valType is never used for anything, we should make it optional until
> such a time as it is.
> Additionally, TrieFloatField (valtype="float|tfloat") types should be OK as a
> field type along with FloatField(valType="pfloat")
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
