[ 
https://issues.apache.org/jira/browse/SOLR-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171641#comment-13171641
 ] 

Erick Erickson commented on SOLR-2906:
--------------------------------------

What do the collective people who actually know the code think about this 
patch? From my perspective, the LFU is a classic alternative to LRU and seems 
like a fine addition. If there are no objections, I'll volunteer to commit this.

Shawn:
This is the kind of thing that could use two things:
1> text for CHANGES.txt describing the new functionality. If you could attach 
that as a separate patch file (or just e-mail it to me) that would be great. 
That file changes rapidly enough that I like to add the text at check-in time, 
it seems easier.

2> Adding a description to the Wiki since this is new functionality. Perhaps in 
http://wiki.apache.org/solr/SolrCaching?
                
> Implement LFU Cache
> -------------------
>
>                 Key: SOLR-2906
>                 URL: https://issues.apache.org/jira/browse/SOLR-2906
>             Project: Solr
>          Issue Type: Sub-task
>          Components: search
>    Affects Versions: 3.4
>            Reporter: Shawn Heisey
>            Priority: Minor
>         Attachments: ConcurrentLFUCache.java, LFUCache.java, SOLR-2906.patch, 
> SOLR-2906.patch, TestLFUCache.java
>
>
> Implement an LFU (Least Frequently Used) cache as the first step towards a 
> full ARC cache

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to