[
https://issues.apache.org/jira/browse/LUCENE-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172277#comment-13172277
]
Michael McCandless commented on LUCENE-3655:
--------------------------------------------
The python style looks great! You don't need to do the C-battle-scars "{{if -1
== XXX:}}" (ie python will catch you if you do "if {{XXX = -1:}}" by accident),
but no need to change that.
libxml2 isn't always available (at least on my OS X box it isn't installed); is
it possible to use the "xml" module instead? Or does it not have the features
you need....? (And, is it always installed...?).
if not, maybe we can make the maven checking optional, ie if the import fails
then you get a warning that maven checking was not done...
I don't feel qualified to understand if the functions are doing the right
thing... but that sure is a LOT of Python code :) Maven requires a lot of
verifying I guess... it's awesome it catches the two problems from 3.5.0.
> Add Maven artifact checks to dev-tools/scripts/smokeTestRelease.py
> ------------------------------------------------------------------
>
> Key: LUCENE-3655
> URL: https://issues.apache.org/jira/browse/LUCENE-3655
> Project: Lucene - Java
> Issue Type: Task
> Components: general/build
> Affects Versions: 3.5
> Reporter: Steven Rowe
> Assignee: Steven Rowe
> Priority: Minor
> Attachments: LUCENE-3655.patch
>
>
> smokeTestRelease.py should examine the Maven artifacts in a Lucene/Solr
> release.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
