[
https://issues.apache.org/jira/browse/LUCENE-3656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172366#comment-13172366
]
Uwe Schindler commented on LUCENE-3656:
---------------------------------------
One more thing, because Robert reminded me:
I changed to use a LinkedHashSet instead simple HashSet, because the caller
adding listeners would expect that they are called in order on close. Adding
them to a HashSet makes they executed in arbitrary order and thats not what a
user expects. The Linked* does not cost us much, as the number of listeners
should be low :-)
> IndexReader's add/removeCloseListener should not use ConcurrentHashMap, just
> a synchronized set
> -----------------------------------------------------------------------------------------------
>
> Key: LUCENE-3656
> URL: https://issues.apache.org/jira/browse/LUCENE-3656
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/index
> Affects Versions: 3.5, 4.0
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Priority: Minor
> Labels: curiosity
> Attachments: LUCENE-3656.patch
>
>
> The use-case for ConcurrentHashMap is when many threads are reading and less
> writing to the structure. Here this is just funny: The only reader is
> close(). Here you can just use a synchronized HashSet. The complexity of CHM
> is making this just a joke :-)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
