[
https://issues.apache.org/jira/browse/LUCENE-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173962#comment-13173962
]
Robert Muir commented on LUCENE-3654:
-------------------------------------
the reason I am -1, I don't want JVM crashes.
This is lucene java, users can expect not to have JVM crashes because of
bytesref
bugs in lucene (this class is used all over the place), they shoudl get AIOOBE
and NPE
and other things.
So all is not fine just because it has a fallback.
Convincing that there is performance win is a waste of time, this method is not
a hotspot.
Convincing me that nobody will get jvm crashes is going to be difficult.
> Optimize BytesRef comparator to use Unsafe long based comparison (when
> possible)
> --------------------------------------------------------------------------------
>
> Key: LUCENE-3654
> URL: https://issues.apache.org/jira/browse/LUCENE-3654
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/index, core/search
> Reporter: Shay Banon
> Attachments: LUCENE-3654.patch
>
>
> Inspire by Google Guava UnsignedBytes lexi comparator, that uses unsafe to do
> long based comparisons over the bytes instead of one by one (which yields
> 2-4x better perf), use similar logic in BytesRef comparator. The code was
> adapted to support offset/length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
