[ 
https://issues.apache.org/jira/browse/SOLR-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182250#comment-13182250
 ] 

Martijn van Groningen commented on SOLR-2072:
---------------------------------------------

Nice prototype! Good idea to use a FieldComparator/Source that sums the score.

I think it is better not to extend AbstractFirstPassGroupingCollector and move 
the code you need to DocScoresFirstPassGroupingCollector. The 
AbstractFirstPassGroupingCollector and its other subclasses only keep the top N 
groups. That is an important difference compared to 
DocScoresFirstPassGroupingCollector.

Another implementation idea that I like is if we create a collector that is 
responsible for filling the FieldComparator/Source (in this case the sums of 
score per group, but might be something different). This collector will create 
the Sort that the first pass grouping collector will use. With this approach 
existing code doesn't have to be changed, the logic is in the FieldComparator. 
The downside is that when a user wants to sort by sum(score), three searches 
are executed per request.
                
> Search Grouping: expand group sort options
> ------------------------------------------
>
>                 Key: SOLR-2072
>                 URL: https://issues.apache.org/jira/browse/SOLR-2072
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Yonik Seeley
>         Attachments: SOLR-2072-01.patch
>
>
> Ability to specify functions over group documents when sorting groups.  
> max(score) or avg(popularity), etc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to