[ 
https://issues.apache.org/jira/browse/LUCENE-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Simon Willnauer updated LUCENE-3689:
------------------------------------

    Attachment: LUCENE-3689.patch

here is a patch that adds closeable to DocValuesConsumer and cleans up resource 
/ stream management. I also renamed finish to flush since thats what it really 
is.


                
> DocValuesConsumer should implement closeable and release resource in close 
> instead of during finish / flush
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3689
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3689
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: core/index
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-3689.patch
>
>
> DocValuesConsumer currently doesn't have a close method and releases its 
> resources during finish / flush. This is confusing, makes debugging more 
> complex and mixes concerns. DocValuesConsumer should impl. Closeable and 
> users should release resources safely.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to