[ 
https://issues.apache.org/jira/browse/LUCENE-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185789#comment-13185789
 ] 

Hoss Man commented on LUCENE-3690:
----------------------------------

bq. I don't think fixing offsets bugs like LUCENE-2208 counts as breaking index 
backwards compat, because it won't change search results.
bq. It will just prevent highlighters from throwing exceptions.

FWIW: If i understand the issue correctly, then the one risk i can imagine here 
is that people don't reindex, and get the new behavior for new docs, so they'll 
get diff behavior are query time depending on when the doc is re-indexed.  that 
seems significant enough to definitely warrant the luceneMatchVersion toggle 
sarowe has on his todo list -- which seems fairly straight forward.

The only concern i really have is...

bq. A JFlex-based HTMLStripCharFilter replacement would be more performant...

..before deprecating "ClassicHTMLStripCharFilter" we should actually test that 
the Jlex version is faster ... because if it winds up being noticible slower in 
some cases, some people may prefer the the "classic" mode to the JFlex mode if 
the "warts" of the existing one don't affect them -- in which case i might 
almost suggest actually using multiple factories in solr instead of making it 
versionMatch dependent.  

(fingers crossed it's a non-issue)
                
> JFlex-based HTMLStripCharFilter replacement
> -------------------------------------------
>
>                 Key: LUCENE-3690
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3690
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: modules/analysis
>    Affects Versions: 3.5, 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3690.patch, LUCENE-3690.patch, LUCENE-3690.patch
>
>
> A JFlex-based HTMLStripCharFilter replacement would be more performant and 
> easier to understand and maintain.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to