[ 
https://issues.apache.org/jira/browse/LUCENE-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186740#comment-13186740
 ] 

Koji Sekiguchi commented on LUCENE-3697:
----------------------------------------

Patch makes sense.

bq. This causes the SimpleFragmentsBuilderTest#testMVSeparator to fail, because 
it has empty string fields which are separated by a custom separator.

Yes. I think that just fixing the expected string in #testMVSeparator is fine.
                
> FastVectorHighlighter SimpleBoundaryScanner does not work well when 
> highlighting at the beginning of the text 
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3697
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3697
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/highlighter
>            Reporter: Shay Banon
>         Attachments: LUCENE-3697.patch
>
>
> The SimpleBoundaryScanner still breaks text not based on characters provided 
> when highlighting text that end up scanning to the beginning of the text to 
> highlight. In this case, just use the start of the text as the offset.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to