[ 
https://issues.apache.org/jira/browse/LUCENE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186979#comment-13186979
 ] 

Michael McCandless commented on LUCENE-3694:
--------------------------------------------

Right, Field.java has setters.

DocValuesField no longer does (nor does NumericField), ie we fixed this issue 
(that these classes were overloading the setters from Field.java).

Or... are you saying this is naming issue?  Ie we can work out the naming (do 
we use setValue(T value) or setT(T value) for Field.java and for the new Norm 
class) here...
                
> DocValuesField should not overload setInt/setFloat etc
> ------------------------------------------------------
>
>                 Key: LUCENE-3694
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3694
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Michael McCandless
>             Fix For: 4.0
>
>
> See my description on LUCENE-3687. In general we should avoid this for 
> primitive types and give them each unique names.
> So I think instead of setInt(byte), setInt(short), setInt(int), setInt(long), 
> setFloat(float) and setFloat(double),
> we should have setByte(byte), setShort(short), setInt(int), setLong(long), 
> setFloat(float) and setDouble(double).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to