[
https://issues.apache.org/jira/browse/SOLR-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197168#comment-13197168
]
Hoss Man commented on SOLR-3060:
--------------------------------
This patch is straight forward and includes tests (thank you so much for the
tests).
The meat of the change is that getHighlightQuery is overridden to attempt query
rewriting, which gives me two concerns...
1) at a minimum i'm pretty sure super.getHighlightQuery still needs to be
called.
2) is this rewriting of hte query done in the SurroundQParser going to cause
any problems or unexpected behavior in conjunction with the highlighter
component logic that already decides if/when to rewrite the query?
If the crux of the problem is that HighlightComponent rewrites the query
automatically _except_ when using the phrase highlighter with the multi-term
option (assuming i'm reading the code correctly) then shouldn't that code path
of the highlighter be modified to do something sane with any type of Query
object? ... why isn't it responsible for calling rewrite on any sub-query of a
type it doesn't understanding?
(Highlighting is one of the areas of Lucene/Solr that frequently makes my head
hurt, so forgive me if these are silly questions)
> add highlighter support to SurroundQParserPlugin
> -------------------------------------------------
>
> Key: SOLR-3060
> URL: https://issues.apache.org/jira/browse/SOLR-3060
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 4.0
> Reporter: Ahmet Arslan
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-3060.patch, SOLR-3060.patch
>
>
> Highlighter does not recognize SrndQuery family.
> http://search-lucene.com/m/FuDsU1sTjgM
> http://search-lucene.com/m/wD8c11gNTb61
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
