[ 
https://issues.apache.org/jira/browse/SOLR-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197487#comment-13197487
 ] 

Hoss Man commented on SOLR-1052:
--------------------------------

bq. This is how config deprecations should work in my opinion. No need to 
advertise to new users the use of a syntax that we want to go away. It would be 
more confusing for the C) people to see deprecation warnings being printed OOTB 
from their brand new search engine without knowing how to fix it

+1

Patch looks good to me.  my one suggestion, since there seems to be consensus 
that solr should complain louder when there are config errors, is that instead 
of removing the existing "warn" calls on those already deprecated Solr 1.x 
legacy conf syntax, why not leave in those checks but the "warn(...)" calls 
with "throw new SolrException(...)" ?

                
> Deprecate/Remove <indexDefaults> in favor of <mainIndex> in solrconfig.xml
> --------------------------------------------------------------------------
>
>                 Key: SOLR-1052
>                 URL: https://issues.apache.org/jira/browse/SOLR-1052
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Assignee: Jan Høydahl
>            Priority: Minor
>              Labels: solrconfig.xml
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-1052-3x.patch
>
>
> Given that we now handle multiple cores via the solr.xml and the discussion 
> around <indexDefaults> and <mainIndex> at 
> http://www.lucidimagination.com/search/p:solr?q=mainIndex+vs.+indexDefaults
> We should deprecate/remove the use of indexDefaults and just rely on 
> mainIndex, as it doesn't seem to serve any purpose and is confusing to 
> explain.    

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to