[ 
https://issues.apache.org/jira/browse/SOLR-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198158#comment-13198158
 ] 

Yonik Seeley commented on SOLR-1726:
------------------------------------

Some other issues:
 - the optimization doesn't work if the docset is also requested (i.e. if 
facet=true) since it's only added in one place.
 - on a quick test, I'm getting a maxScore=NaN
{code}
<result name="response" numFound="29" start="0" maxScore="NaN">
{code}
Not sure if that's expected, but it's likely to mess up at least some clients
 - when using pageDoc, the results get incorrectly cached as a non-paged query 
(and hence other requests that use the same query will be incorrect)
 - when using pageDoc, any previous cached queries will be incorrectly used and 
hence incorrect results will be returned
 - it was pretty easy to cause a NPE (but I haven't had time to look into the 
causes yet):
http://localhost:8983/solr/select?q=*:*&pageDoc=20&pageScore=1.0&fl=[docid],score
{code}
java.lang.NullPointerException
        at 
org.apache.solr.handler.component.QueryComponent.process(QueryComponent.java:566)
        at 
org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:203)
{code}
 - if you look at the test for this, the query only ever matches a single doc!  
Given that the test actually passes while trying to use paging actually means 
that paging isn't working (since the second page should obviously yield no 
results).

I've disabled this for now since it's not ready for prime-time and since it 
messes with non-deep-paged results.
                
> Deep Paging and Large Results Improvements
> ------------------------------------------
>
>                 Key: SOLR-1726
>                 URL: https://issues.apache.org/jira/browse/SOLR-1726
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: CommonParams.java, QParser.java, QueryComponent.java, 
> ResponseBuilder.java, SOLR-1726.patch, SOLR-1726.patch, 
> SolrIndexSearcher.java, TopDocsCollector.java, TopScoreDocCollector.java
>
>
> There are possibly ways to improve collections of "deep paging" by passing 
> Solr/Lucene more information about the last page of results seen, thereby 
> saving priority queue operations.   See LUCENE-2215.
> There may also be better options for retrieving large numbers of rows at a 
> time that are worth exploring.  LUCENE-2127.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to