[ 
https://issues.apache.org/jira/browse/SOLR-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199930#comment-13199930
 ] 

Hoss Man commented on SOLR-3093:
--------------------------------

I think yonik's point is that unlike things in SOLR-1052 where existing users 
would have a reasonable expectation that the syntax would definitively do 
something (ie: use specific classes/settings), the config in this issue was 
_always_ just an optimization hint, and the system ultimately works fine even 
if/when it is ignored.

Personally i think that in these cases, it would be sufficient to WARN that 
these optimization hints are no longer used and being ignored so people can 
clean up if/when they want, but since they don't *have* to change anything to 
have a working solr instance (that still externally behaves the way it would in 
older versions of solr) there's no reason to FAIL and annoy them.


                
> Remove unused features <boolTofilterOptimizer> and <HashDocSet>
> ---------------------------------------------------------------
>
>                 Key: SOLR-3093
>                 URL: https://issues.apache.org/jira/browse/SOLR-3093
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Jan Høydahl
>             Fix For: 3.6, 4.0
>
>
> SolrConfig.java still tries to parse <boolTofilterOptimizer>
> But the only user of this param was SolrIndexSearcher.java line 366-381 which 
> is commented out.
> Probably the whole logic should be ripped out, and we fail hard if we find 
> this config option in solrconfig.xml
> Also, the <HashDocSet> config option is old and no longer used or needed? 
> There is some code which tries to use it but I believe that since 1.4 there 
> are more efficient ways to do the same. Should we also fail-fast if found in 
> config or only print a warning?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to