[
https://issues.apache.org/jira/browse/LUCENE-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205583#comment-13205583
]
Simon Willnauer commented on LUCENE-3769:
-----------------------------------------
mike, I like the simplification. I think we talked about this last time we
touched this code already. I think this is the most common use-case... Yet, I
don't think NRTManager should expose IndexSearcher directly. Think of an app
that either uses NRT or commit / reopen ie. uses a NRTManager and a
PlainOldIndexManager. From a user perspective SearcherManager is the main
interface to search the index no matter how you commit / flush / NRT etc. I'd
rather keep it exposing the SM instead.
about TrackingIndexWriter - I think we should fix IW to use seq ids eventually
but I think for this purpose its fine.
> Simplify NRTManager
> -------------------
>
> Key: LUCENE-3769
> URL: https://issues.apache.org/jira/browse/LUCENE-3769
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/search
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3769.patch
>
>
> NRTManager is hairy now, because the applyDeletes is separately passed
> to ctor, passed to maybeReopen, passed to getSearcherManager, etc.
> I think, instead, you should pass it only to the ctor, and if you have
> some cases needing deletes and others not then you can make two
> NRTManagers. This should be no less efficient than we have today,
> just simpler.
> I think it will also enable NRTManager to subclass ThingyManager
> (LUCENE-3761).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
