Ideally the license checking java code would be a checked-in jar containing an ant task, so that it wouldn't need to be compiled on every build. I don't want to tackle that right now though.
In https://issues.apache.org/jira/browse/LUCENE-3267 Chris Male removed checking of contrib/queries/lib/ from check-legal-lucene's list of lib dirs, which apparently was otherwise not maintained at all, so that now only lucene/lib/ is ever checked. There two other existing lucene lib/ dirs are under the sandbox contrib and the demo contrib. Solr, by contrast, has a more up-to-date list of directories to check, but it too suffers from module drift: contrib/langid/lib/ is missing, and dataimporthandler-extras/lib/ doesn't exist (anymore). modules/ on trunk has no license checking coverage at all. Per-module invocation, which I was considering, is problematic for Solr, since the example, which isn't exactly a module, has three separate lib/ directories. My current thinking is that the license checking code should be invoked once per module, and that each module can have a set of lib/ directories associated with it. By default, that set would consist only of the lib/ directory associated with the module, but solr/core/ and lucene/core/ would specialize the set: lucene/core/ would include lucene/lib/, and solr/core/ would include solr/lib/ and also all the example/**/lib/ dirs. Steve > -----Original Message----- > From: Steven A Rowe [mailto:sar...@syr.edu] > Sent: Friday, February 10, 2012 12:43 PM > To: dev@lucene.apache.org > Subject: RE: check-legal-lucene invoked repeatedly? > > I'll take a look. Actually, I remember thinking a while back that the > best way to do this is to check each module's lib/ dir when the module is > being tested, unlike the current setup, where all dirs are checked at > once. That way people don't have to remember to update the global list. > > > -----Original Message----- > > From: dawid.we...@gmail.com [mailto:dawid.we...@gmail.com] On Behalf Of > > Dawid Weiss > > Sent: Friday, February 10, 2012 12:35 PM > > To: dev@lucene.apache.org > > Subject: Re: check-legal-lucene invoked repeatedly? > > > > > No, it doesn't need to be invoked multiple times - it just needs to > run > > once per build session. > > > > That's what I thought. It gets invoked a number of times -- check this > > out: > > https://builds.apache.org/job/Lucene-Solr-tests-only-trunk- > > java7/1712/consoleFull > > > > and these calls are relatively costly. > > > > > Maybe it could be hooked into lucene core's build, with a property > that > > gets set and checked so it runs just once? > > > > I think this makes sense. Do you know how to fix it, Steven? If you do > > it may be faster than me grepping through the build files :) > > > > Dawid > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > > For additional commands, e-mail: dev-h...@lucene.apache.org
