[ 
https://issues.apache.org/jira/browse/SOLR-3076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mikhail Khludnev updated SOLR-3076:
-----------------------------------

    Attachment: child-bjqparser.patch

Some news in attach child-bjqparser.patch.

Good stuff - I added ToChild parser, bad thing is that ToChildBJQ seems to have 
a filtered search bug. See below.

Hoss,
I covered all your points about tests. Also I want to add deleted blocks 
coverage. 

h2. Syntax:
* {code}
{!parent which="PARENT:true"}CHILD_PRICE:10
{!child of="PARENT:true"}PARENT_PRICE:10
{code}
* cool EntityRelationships schema is descoped
* I don't think that swapping local and param ({!parent 
of="child_names:b"}parent:true) is user friendly 
* still asking for using master-detail in favour of parent child. WDYT?

h2. ToChildBJQ vs filtered search

Michael,
* I briefly looked into the TestBlockJoin.testSimple(). It asserts filtered 
search for children by "skill":"foosball" but I can't find such term in data.
* I added two plain asserts one of them is failed on erroneous 0 docnum in 
result. (testSimple fails after applying child-bjqparser.patch). 
* TestBJQParser.testChildrenParser() is ignored in the patch. Looks like it 
fails due to another reason. Pls find my concerns in @Ignore comment. 



                
> Solr should support block joins
> -------------------------------
>
>                 Key: SOLR-3076
>                 URL: https://issues.apache.org/jira/browse/SOLR-3076
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Grant Ingersoll
>         Attachments: SOLR-3076.patch, SOLR-3076.patch, SOLR-3076.patch, 
> bjq-vs-filters-backward-disi.patch, bjq-vs-filters-illegal-state.patch, 
> child-bjqparser.patch, parent-bjq-qparser.patch, parent-bjq-qparser.patch, 
> solrconf-bjq-erschema-snippet.xml
>
>
> Lucene has the ability to do block joins, we should add it to Solr.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to