[ 
https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212674#comment-13212674
 ] 

Robert Muir commented on LUCENE-3736:
-------------------------------------

{quote}
(after the heavy commit of Robert, rev. 1291679)
{quote}

Hey, maybe only a medium-heavy commit: i did reply to the jenkins failure with 
a patch to the list before committing :)

{quote}
The new implementation builds the ParallelFields instance using the FieldsEnums 
of the parallel readers, which is much more correct than iterating FieldInfos 
and checking for indexed fields.
{quote}

+1, when debugging i was a little confused not just about how it was built but 
where in the code... I think this is more intuitive!
                
> ParallelReader is now atomic, rename to ParallelAtomicReader and also add a 
> ParallelCompositeReader (that requires LogDocMergePolicy to have identical 
> subreader structure)
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3736
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3736
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: core/index
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 4.0
>
>         Attachments: LUCENE-3736-improveTestCoverage.patch, 
> LUCENE-3736-readerMaps.patch, LUCENE-3736.patch, LUCENE-3736.patch, 
> LUCENE-3736.patch, LUCENE-3736.patch, LUCENE-3736.patch, LUCENE-3736.patch, 
> LUCENE-3736.patch, LUCENE-3736.patch, LUCENE-3736.patch, LUCENE-3736.patch, 
> LUCENE-3736.patch
>
>
> The plan is:
> - Move all subreaders to ctor (builder-like API. First build reader-set, then 
> call build)
> - Rename ParallelReader to ParallelAtomicReader
> - Add a ParallelCompositeReader with same builder API, but taking any 
> CompositeReader-set and checks them that they are aligned (docStarts 
> identical). The subreaders are ParallelAtomicReaders.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to