[ https://issues.apache.org/jira/browse/LUCENE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214565#comment-13214565 ]
Robert Muir commented on LUCENE-3360: ------------------------------------- FieldCache only takes AtomicReader now... so the insanity trap is already removed in trunk. We have alternative ways to 'fieldcache' at index-time, by using SortedBytes docvalues field. I was originally skeptical of SortedBytes (especially given its initial impl problems), but its been cleaned up a lot recently, I think its the direction should really move forwards to. There is also progress on more efficient implementations by doing more at indexing time: e.g. LUCENE-3729 As an "index" the idea is to compute things up-front so that searches are faster: I don't think lucene core needs to support 'uninverting at runtime' ?! So I think we should start a plan for how FieldCache can be moved to contrib or deprecated instead. > Move FieldCache to IndexReader > ------------------------------ > > Key: LUCENE-3360 > URL: https://issues.apache.org/jira/browse/LUCENE-3360 > Project: Lucene - Java > Issue Type: Improvement > Reporter: Martijn van Groningen > Fix For: 3.6, 4.0 > > Attachments: LUCENE-3360-3x.patch, LUCENE-3360-3x.patch, > LUCENE-3360-3x.patch, LUCENE-3360.patch, LUCENE-3360.patch, > LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch, LUCENE-3360.patch, > LUCENE-3360.patch > > > Move the static FieldCache.DEFAULT field instance to atomic IndexReaders, so > that FieldCache insanity caused by the WeakHashMap no longer occurs. > * Add a new method to IndexReader that by default throws an UOE: > {code}public FieldCache getFieldCache(){code} > * The SegmentReader implements this method and returns its own internal > FieldCache implementation. This implementation just uses a > HashMap<Entry<T>,Object>> to store entries. > * The SlowMultiReaderWrapper implements this method as well and basically > behaves the same as the current FieldCacheImpl. > This issue won't solve the insanity that comes from inconsistent usage of a > single field (for example retrieve both int[] and DocTermIndex for the same > field). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org