[ https://issues.apache.org/jira/browse/SOLR-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216796#comment-13216796 ]
Bill Bell commented on SOLR-2393: --------------------------------- Jan... So we would switch from - {code} <filter class="solr.PhoneticFilterFactory" encoder="DoubleMetaphone" inject="false"/> or <filter class="solr.DoubleMetaphoneFilterFactory" inject="false"/> {code} to the following... So we would have these 2 cases? Is that how you understand it? {code} <fieldtype name="phonetic" stored="false" indexed="true" class="solr.TextField" > <analyzer> <tokenizer class="solr.StandardTokenizerFactory"/> <filter class="solr.PhoneticFilterFactory" encoder="Phonetic" inject="false"/> </analyzer> </fieldtype> <fieldtype name="phonetic" stored="false" indexed="true" class="solr.TextField" > <analyzer> <tokenizer class="solr.StandardTokenizerFactory"/> <filter class="solr.PhoneticFilterFactory" encoder="DoubleMetaphone" inject="false"/> </analyzer> </fieldtype> {code} > Clean up Double Metaphone code (PhoneticFilterFactory and > DoubleMetaphoneFilter) > -------------------------------------------------------------------------------- > > Key: SOLR-2393 > URL: https://issues.apache.org/jira/browse/SOLR-2393 > Project: Solr > Issue Type: Improvement > Affects Versions: 4.0 > Reporter: Bill Bell > > From Ryan McKinley to Jan Høydahl: > PhoneticFilterFactory could check > "DoubleMetaphone".equals( encoder ) and then create the specialized > Filter. > I don't feel strongly, but we could have: > EncoderFilter -- just uses 'encode()' > DoubleMetaphoneFilter - uses special double metaphone stuff > EncoderFilterFactory -- always uses EncoderFilter, and is not > semantically bound to 'phonetic' > PhoneticFilterFactory -- picks the best phonetic filter impl (encoder > or double metaphone) > then deprecate: > PhoneticFilter > DoubleMetaphoneFilterFactory -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org