[ 
https://issues.apache.org/jira/browse/SOLR-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217934#comment-13217934
 ] 

Hoss Man commented on SOLR-3156:
--------------------------------

Luca: the change to SolrCore looks good to me ... the one thing i might suggest 
is adding an ERROR log just before you throw the exception (i'm in the "log 
early" team)

The test looks awesome, but *PLEASE* trim those solrconfig files down so that 
they only contain the 5-6 minimum lines they need inorder for the test to be 
meaningful ... we have far too many big bloated test configs already, the goal 
is to stop adding new ones and make sure each test config has a specific and 
easy to see purpose.
                
> Check for locks on startup
> --------------------------
>
>                 Key: SOLR-3156
>                 URL: https://issues.apache.org/jira/browse/SOLR-3156
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Luca Cavanna
>         Attachments: SOLR-3156.patch
>
>
> When using simple or native lockType and the application server is not 
> shutdown properly (kill -9), you don't notice problems until someone tries to 
> add or delete a document. In fact, you get errors every time Solr opens a new 
> IndexWriter on the "locked" index. I'm aware of the unlockOnStartup option, 
> but I'd prefer to know and act properly when there's a lock, and I think it 
> would be better to know on startup, since Solr is not going to work properly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to