[
https://issues.apache.org/jira/browse/SOLR-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218816#comment-13218816
]
Hoss Man commented on SOLR-3157:
--------------------------------
{quote}
IMO, it's actually higher importance that we have better logging for ourselves
so we can more easily debug our tests.
{quote}
agreed ... but we shouldn't break the log format of the most important line
Solr logs if we can avoid it (particularly since the format was chosen
specifically to be easy to parse).
i also don't understand why you think those changes to SolrCore.execute's
"info" log make anything better? your change _removed_ really useful info and
made the messages harder to parse because it removed the consistent key=val
pattern for the path & param vals.
{quote}
Maybe there's a way I can log different things when using the test formatter
and restore the production log format to it's former glory.
{quote}
I don't understand why the structure of the _string_ used in this one info
message has anything to do with your goal of better test logging using the
SolrLogFormatter? why can't that _string_ format stay exactly identical
regardless of whether it's in a test (and the _record_ gets formated with all
of your new thread and meatdata goodness) or not ?
as things stand now (with your latest commit #1294911) these messages are still
broken compared to 3x because they don't include the SolrCore name (the "logid"
used to init the StringBuilder before you changed it) ... that seems pretty
damn important (although i realize now i somehow didn't mention that in my
earlier comment)
{noformat}
3x example...
Feb 28, 2012 5:38:33 PM org.apache.solr.core.SolrCore execute
INFO: [core0] webapp=/solr path=/select/ params={q=*:*&sort=score+desc} hits=0
status=0 QTime=11
trunk example...
Feb 28, 2012 5:39:02 PM org.apache.solr.core.SolrCore execute
INFO: webapp=/solr path=/select/ params={q=*:*&sort=score+desc} hits=0 status=0
QTime=40
{noformat}
> custom logging
> --------------
>
> Key: SOLR-3157
> URL: https://issues.apache.org/jira/browse/SOLR-3157
> Project: Solr
> Issue Type: Test
> Reporter: Yonik Seeley
> Priority: Blocker
> Attachments: SOLR-3157.patch, jetty_threadgroup.patch
>
>
> We need custom logging to decipher tests with multiple core containers,
> cores, in a single JVM.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
