[
https://issues.apache.org/jira/browse/LUCENE-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220874#comment-13220874
]
Robert Muir commented on LUCENE-3801:
-------------------------------------
I think this might not be hard to fix, consider my comparator:
{code}
// compares just the weight side of the pair
static final Comparator<Pair<Long,Long>> minPairWeightComparator = new
Comparator<Pair<Long,Long>> () {
public int compare(Pair<Long,Long> left, Pair<Long,Long> right) {
return left.output1.compareTo(right.output1);
}
};
{code}
Instead of looking for a NO_OUTPUT path, I think we should instead express
"output == NO_OUTPUT" as "comparator.compare(previousOutput, output) == 0",
Ill rerun benchmarks but i don't think this will hurt.
> Generify FST shortestPaths() to take a comparator
> -------------------------------------------------
>
> Key: LUCENE-3801
> URL: https://issues.apache.org/jira/browse/LUCENE-3801
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/FSTs
> Affects Versions: 3.6, 4.0
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-3801.patch, LUCENE-3801.patch
>
>
> Not sure we should do this, it costs 5-10% performance for WFSTSuggester.
> But maybe we can optimize something here, or maybe its just no big deal to us.
> Because in general, this could be pretty powerful, e.g. if you needed to
> store
> some custom stuff in the suggester, you could use pairoutputs, or whatever.
> And the possibility we might need shortestPaths for other cool things... at
> the
> least I just wanted to have the patch up here.
> I haven't tested this on pairoutputs... but i've tested it with e.g.
> FloatOutputs
> and other things and it works fine.
> I tried to minimize the generics violations, there is only 1 (cannot create
> generic array).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
