[
https://issues.apache.org/jira/browse/SOLR-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222379#comment-13222379
]
Yonik Seeley commented on SOLR-2719:
------------------------------------
I've been saying for a while that using roughly java identifiers for field
names was best practice, but we should document it somewhere.
I don't think we should change StrParser.getId to be more permissive though -
that will just cause more problems in the future (say when we want to start
adding infix and want a-b to be a minus b. There's not a regression in that
specific code since the function parser has never accepted "-" as part of a
field name.
> REGRESSION ReturnFields incorrect parse fields with hyphen - breaks existing
> "fl=my-field-name" type usecases
> -------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-2719
> URL: https://issues.apache.org/jira/browse/SOLR-2719
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 4.0
> Reporter: Nik V. Babichev
> Priority: Blocker
> Labels: field, fl, query, queryparser
> Fix For: 4.0
>
> Attachments: SOLR-2719.patch
>
>
> fl=my-hyphen-field in query params parsed as "my" instead of
> "my-hyphen-field".
> OAS.search.ReturnFields use method getId() from OAS.search.QueryParsing
> in which check chars "if (!Character.isJavaIdentifierPart(ch) && ch != '.')"
> Hyphen is not JavaIdentifierPart and this check break when first "-" is found.
> This problem solve by passing '-' to check:
> if (!Character.isJavaIdentifierPart(ch) && ch != '.' && ch != '-') break;
> But I don't know how it can affect on whole project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
