[ 
https://issues.apache.org/jira/browse/SOLR-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223080#comment-13223080
 ] 

Emmanuel Bourg commented on SOLR-3204:
--------------------------------------

Hi all and thank you for your quick reply. This is not a "simple" Maven 
metadata issue. Even if you consider solr-commons-csv to be an internal part of 
Solr it's now a public Maven artifact that people are starting to use in their 
projects (The Apache Commons teams even starts receiving bug reports for 
solr-commons-csv). When Commons CSV is officially released there will be a 
conflict if solr-commons-csv and commons-csv are both brought to the classpath 
through the transitive dependencies of a project, because they have the same 
classes in the same package.

Imagine a project using Solr and doing CSV stuff with Commons CSV, when the 
CSVParser classes is instantiated it can be either the one from 
solr-commons-csv or the one from Commons CSV, this is guaranteed to break badly.

The right approach is to change the package of solr-commons-csv, for example to 
org.apache.solr.commons.csv, so both solr-commons-csv and Commons CSV can 
coexist on the classpath without conflict. This can be automated with the Maven 
Shade plugin.


                
> solr-commons-csv must not use the org.apache.commons.csv package
> ----------------------------------------------------------------
>
>                 Key: SOLR-3204
>                 URL: https://issues.apache.org/jira/browse/SOLR-3204
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 3.5
>            Reporter: Emmanuel Bourg
>            Priority: Blocker
>             Fix For: 3.6
>
>
> The solr-commons-csv artifact reused the code from the Apache Commons CSV 
> project but the package wasn't changed to something else than 
> org.apache.commons.csv in the process. This creates a compatibility issue as 
> the Apache Commons team works toward an official release of Commons CSV. It 
> prevents Commons CSV from using its own org.apache.commons.csv package, or 
> forces the renaming of all the classes to avoid a classpath conflict.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to