[ https://issues.apache.org/jira/browse/LUCENE-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223271#comment-13223271 ]
Robert Muir commented on LUCENE-3853: ------------------------------------- Hi Benson, thanks for the patch. I think it would be better though if our example didnt recommend MultiFields (or at least noted that this is the slow/trappy way to access terms) Also we need some null checks I think in the example, because e.g. fields() is allowed to return null, so it should be checked before it has an iterator... but i think this is overall a great idea? perhaps if we come up with a good example we can think of a place in the javadocs it could reside as well, so its not just in the migration guide (e.g. if you are a new Lucene user, you likely wouldnt even look at MIGRATE.txt but this would still be useful). > Improve CHANGES.txt for FieldsEnum/TermsEnum > -------------------------------------------- > > Key: LUCENE-3853 > URL: https://issues.apache.org/jira/browse/LUCENE-3853 > Project: Lucene - Java > Issue Type: Bug > Components: core/other > Affects Versions: 4.0 > Reporter: Benson Margulies > Attachments: LUCENE-3853.patch > > > The text in CHANGES.txt that explains the new situation with FieldsEnum > doesn't explain how to get one, and the explanation of TermEnum seems not to > have kept up with the code. here's a patch to CHANGES.txt. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org