[ 
https://issues.apache.org/jira/browse/SOLR-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230408#comment-13230408
 ] 

Luca Cavanna commented on SOLR-3207:
------------------------------------

The first letter should be ok as checked in my patch. Regarding the trailing 
characters, do you mean we shouldn't use isJavaIdentifierPart anymore but 
something else? That's even more restrictive than my patch since I've used the 
existing rules applied while parsing the fl parameter (ReturnFields class). No 
problem for me, are we all sure we want to proceed this way?

I'll update my patch later on. Then I'd document this within the Schema wiki 
page. 

That's a big change, any opinion is welcome!
                
> Add field name validation
> -------------------------
>
>                 Key: SOLR-3207
>                 URL: https://issues.apache.org/jira/browse/SOLR-3207
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 4.0
>            Reporter: Luca Cavanna
>             Fix For: 4.0
>
>         Attachments: SOLR-3207.patch
>
>
> Given the SOLR-2444 updated fl syntax and the SOLR-2719 regression, it would 
> be useful to add some kind of validation regarding the field names you can 
> use on Solr.
> The objective would be adding consistency, allowing only field names that you 
> can then use within fl, sorting etc.
> The rules, taken from the actual StrParser behaviour, seem to be the 
> following: 
> - same used for java identifiers (Character#isJavaIdentifierPart), plus the 
> use of trailing '.' and '-'
> - for the first character the rule is Character#isJavaIdentifierStart minus 
> '$' (The dash can't be used as first character (SOLR-3191) for example)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to