[ 
https://issues.apache.org/jira/browse/LUCENE-3938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243854#comment-13243854
 ] 

Martijn van Groningen commented on LUCENE-3938:
-----------------------------------------------

Thanks for taking a look at it!

bq. I'm confused: when you say "parent child document", what does that mean...?
Yes, that is confusing... I actually meant parent child relation. The 
TopParentChildCollector collects the top N matching parent child relations. The 
ParentChildResolveCollector collects parent and child documents belonging to 
the top N parent child relations. 

bq. Ie, it looks like your Query is free to match both parent and child 
documents...? (Unlike index-time joins).
Basically the collectors make a parent child result list for any documents 
matching any query, so that is a difference between index time join impl and 
this impl. 

bq. Minor: maybe break out ParentChildHit into its own source file...?
Sure and if the ParentChildHit is a public class then the ParentChildDoc class 
can be merged with the ParentChildHit class. I think that makes it more clear.
                
> Add query time parent child search
> ----------------------------------
>
>                 Key: LUCENE-3938
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3938
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: modules/join
>            Reporter: Martijn van Groningen
>         Attachments: LUCENE-3938.patch
>
>
> At the moment there is support for index time parent child search with two 
> queries implementations and a collector. The index time parent child search 
> requires that documents are indexed in a block, this isn't ideal for 
> updatability. For example in the case of tv content and subtitles (both being 
> separate documents). Updating already indexed tv content with subtitles would 
> then require to also re-index the subtitles.
> This issue focuses on the collector part for query time parent child search. 
> I started a while back with implementing this. Basically a two pass search 
> performs a parent child search. In the first pass the top N parent child 
> documents are resolved. In the second pass the parent or top N children are 
> resolved (depending if the hit is a parent or child) and are associated with 
> the top N parent child relation documents. Patch will follow soon.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to