On Mon, Apr 2, 2012 at 12:59 PM, Dawid Weiss <[email protected]> wrote: > I'm afraid I'll have to say no to this. > > Carrot2 depends on many external libraries (much like Solr). You have > the freedom (or not) of shading or obfuscating or repackaging. Even > overriding with an explicit version of a given library as much as it's > API compatible with what the POM declares.
Dawid, I don't think that you (carrot as a library) should do any shading. I think that when someone prepares a Solr component including carrot, that they should avoid dependencies that possibly conflict. Jackson is a particular risk factor, since 'minor' versions are mutually incompatible, so the presence of Jackson x.y precludes the use of some other package that requires jackson x.z. -benson > > Repackaging is fun but it's not a cure for all the problems. > > Dawid > > On Mon, Apr 2, 2012 at 6:55 PM, Benson Margulies <[email protected]> > wrote: >> On Mon, Apr 2, 2012 at 12:49 PM, Stanislaw Osinski >> <[email protected]> wrote: >>> I think this is because the Carrot2 update to version 3.5.0.1 >>> (https://issues.apache.org/jira/browse/SOLR-3294) went only to the 3.x >>> branch, leaving trunk with the slightly older 3.5.0 version. There shouldn't >>> be any problems with applying the same update on trunk I think. This would >>> bring all the dependencies in sync. >> >> I think that you should 'shade' (package rename) carrot to hide the >> Jackson dependences. >>> >>> S. >>> >>> >>> On Mon, Apr 2, 2012 at 18:36, Robert Muir <[email protected]> wrote: >>>> >>>> while reviewing dependencies, this looked funky: >>>> >>>> trunk: >>>> jackson-core-asl: 1.5.2 >>>> jackson-mapper-asl: 1.5.2 >>>> >>>> 3.x: >>>> jackson-core-asl: 1.7.4 >>>> jackson-mapper-asl: 1.7.4 >>>> >>>> Is this a mistake? or does jackson release numbers backwards? >>>> or is it intentional? if so I'd like to just add a comment... >>>> >>>> -- >>>> lucidimagination.com >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: [email protected] >>>> For additional commands, e-mail: [email protected] >>>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
