[ 
https://issues.apache.org/jira/browse/SOLR-3316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248252#comment-13248252
 ] 

Robert Muir commented on SOLR-3316:
-----------------------------------

Some parts of the patch make it difficult to review:
* why does SimpleEndResultTransformer.transform lose its @Override?
* why does GroupedEndResultTransformer/SimpleEndResultTransformer.transform 
gain an {@inheritDoc}? I'm not sure this will really do what you expect, 
because it extends a package-private method (EndResultTransformer.inheritDoc), 
which we don't generate javadocs for (only public, protected).


                
> Distributed Grouping fails in some scenarios.
> ---------------------------------------------
>
>                 Key: SOLR-3316
>                 URL: https://issues.apache.org/jira/browse/SOLR-3316
>             Project: Solr
>          Issue Type: Bug
>          Components: SearchComponents - other
>    Affects Versions: 3.4, 3.5
>         Environment: Windows 7, JDK 6u26
>            Reporter: Cody Young
>            Assignee: Martijn van Groningen
>              Labels: distributed, grouping
>         Attachments: SOLR-3316-3x.patch, SOLR-3316.patch, 
> TestDistributedGrouping.java.patch
>
>
> During a distributed grouping request, if rows is set to 0 a 500 error is 
> returned.
> If groups are unique to a shard and the row count is set to 1, then the 
> matches number is only the matches from one shard.
> I've put together a failing test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to