[ 
https://issues.apache.org/jira/browse/SOLR-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250733#comment-13250733
 ] 

Steven Rowe commented on SOLR-3344:
-----------------------------------

bq. I think that it's reasonable for the test framework jar to list it as a 
required dependency, since tests in there depend on it. However, there is an 
alternative (other than nothing): list it again as an optional dependency in 
test-framework, just to give people a hint, and/or change the javadoc for the 
BaseDistributedTestCase to note this requirement. 

I assume you're referring to {{BaseDistributed*Search*TestCase}}, which depends 
on solr-core's {{oas.client.solrj.embedded.JettySolrRunner}}?

I like the optional dependencies alternative better: add optional jetty 
dependencies to Solr test-framework, and change the javadoc for 
BaseDistributedSearchTestCase to note this requirement.
                
> POM dependencies not all there yet for solr-test-framework
> ----------------------------------------------------------
>
>                 Key: SOLR-3344
>                 URL: https://issues.apache.org/jira/browse/SOLR-3344
>             Project: Solr
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 4.0
>            Reporter: Benson Margulies
>         Attachments: 0001-Add-jetty-deps.patch
>
>
> The pom for solr-test-framework does not mention jetty, so a test case that 
> doesn't get jetty into it's classpath otherwise fails with:
> {noformat}
> java.lang.NoClassDefFoundError: org/eclipse/jetty/server/SessionIdManager
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to