[
https://issues.apache.org/jira/browse/LUCENE-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252735#comment-13252735
]
Hoss Man commented on LUCENE-3973:
----------------------------------
bq. How should the analysis be integrated in our build? Need to work out when
the analysis should run, how it should be incorporated in Ant and/or Maven,
what impact errors should have.
i would suggest going about it incrementally...
* hook into build.xml as optional targets that can be run if you have the
neccessary libs installed, don't fail the build just generate the XML report
files
* put the needed libs on builds.apache.org, and hook it into the jenkins
nightly target, and configure jenkins to display it's pretty version of the xml
reports so people can at least see what's going on.
* start adding/tweaking custom rule sets in dev-tools to eliminate rules we
don't care about, add rules we want that don't exist, or change the severity of
rules we think are more/less important
* tweak the build.xml to fail if anything above some arbitrary severity is
tripped
* worry about maven
> Incorporate PMD / FindBugs
> --------------------------
>
> Key: LUCENE-3973
> URL: https://issues.apache.org/jira/browse/LUCENE-3973
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/build
> Reporter: Chris Male
>
> This has been touched on a few times over the years. Having static analysis
> as part of our build seems like a big win. For example, we could use PMD to
> look at {{System.out.println}} statements like discussed in LUCENE-3877 and
> we could possibly incorporate the nocommit / @author checks as well.
> There are a few things to work out as part of this:
> - Should we use both PMD and FindBugs or just one of them? They look at code
> from different perspectives (bytecode vs source code) and target different
> issues. At the moment I'm in favour of trying both but that might be too
> heavy handed for our needs.
> - What checks should we use? There's no point having the analysis if it's
> going to raise too many false-positives or problems we don't deem
> problematic.
> - How should the analysis be integrated in our build? Need to work out when
> the analysis should run, how it should be incorporated in Ant and/or Maven,
> what impact errors should have.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
