[ 
https://issues.apache.org/jira/browse/LUCENE-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dawid Weiss updated LUCENE-3971:
--------------------------------

    Attachment: LUCENE-3971.patch

This code is one hairy bastard... the LinkedList<Character> is scary and so is 
the logic of counting position offset updates... 

This patch fixes the failing tests but I wouldn't guarantee it fixes all the 
problems.

Definitely a candidate for clean rewrite.
                
> MappingCharFilter rarely has wrong correctOffset (for finalOffset) 
> -------------------------------------------------------------------
>
>                 Key: LUCENE-3971
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3971
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/analysis
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-3971.patch, LUCENE-3971_test.patch
>
>
> Found this bug over on LUCENE-3969, but I'm currently tracking a ton of bugs, 
> so
> I figure I would open an issue and see if this one is obvious to anyone:
> Consider this input string: "gzw f quaxot" (length = 12) with a 
> WhitespaceTokenizer.
> If i have mapping rules like this, then it works!:
> {noformat}
> "t" => ""
> {noformat}
> But if I have mapping rules like this:
> {noformat}
> "t" => ""
> "tmakdbl" => "c"
> {noformat}
> Then it will compute final offset wrong:
> {noformat}
>     [junit] junit.framework.AssertionFailedError: finalOffset  expected:<12> 
> but was:<11>
> {noformat}
> Looks like some logic/recursion bug in the correctOffset method? The second 
> rule is not even "used" for this string,
> it just happens to also start with 't'

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to