[
https://issues.apache.org/jira/browse/SOLR-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-2690:
---------------------------
Attachment: SOLR-2690.patch
updated patch with tests.
still a few TODOs and nocommits related to validating the TZ param:
TimeZone.getTimeZone happily accepts gibberish and returns GMT instead -- which
would be really confusing if Solr is running on a server with an older tzdata
file and the client tried to specify some relatively new timezone, silently
getting GMT instead.
There is a TimeZone.getAvailableIDs method that we could use to do a quick
check, but that would only cover named TimeZones (ie: "America/Los_Angeles") so
we have to explicitly validate if it's a legal "CustomID" (ie: "GMT+/-\d+) ...
need another 30 minutes or so at some point to wrap that logic up into a static
utility that can be used by both SolrRequestInfo and the test classes
> Date Math should allow clients to override timezone used for rounding
> (faceting & queries)
> ------------------------------------------------------------------------------------------
>
> Key: SOLR-2690
> URL: https://issues.apache.org/jira/browse/SOLR-2690
> Project: Solr
> Issue Type: Improvement
> Reporter: David Schlotfeldt
> Assignee: Hoss Man
> Attachments: SOLR-2690.patch, SOLR-2690.patch,
> add-tz-parameter.patch, add-tz-parameter.patch, timezone-facet-component.tgz
>
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> Timezone needs to be taken into account when doing date math. Currently it
> isn't. DateMathParser instances created are always being constructed with
> UTC. This is a huge issue when it comes to faceting. Depending on your
> timezone day-light-savings changes the length of a month. A facet gap of
> +1MONTH is different depending on the timezone and the time of the year.
> I believe the issue is very simple to fix. There are three places in the code
> DateMathParser is created. All three are configured with the timezone being
> UTC. If a user could specify the TimeZone to pass into DateMathParser this
> faceting issue would be resolved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
