[ 
https://issues.apache.org/jira/browse/SOLR-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260717#comment-13260717
 ] 

Robert Muir commented on SOLR-3405:
-----------------------------------

OK i'll go change it to use a patched guava jar. Now what?

Now its a serious problem for maven (and we have to make either a "solr-guava" 
fake release, or suck in all of their code).

But its no problem for any of our other packaging:
* source build can download + patch
* binary dist doesn't include guava jar anyway

This needs to be fixed (maven should be equivalent to binary packaging), or we 
shouldn't publish any maven at all.

So maven just needs the .war, and the solrj in its artifacts. it doesnt need 
all this other stuff.
this makes like 50 or so third party dependencies so much simpler.

The reduced exposure prevents things like commons-csv problems (totally 100% a 
maven problem, as I've always said, look at my comment above)

it also makes it so that PMC members who don't understand maven, can simply 
look at the binary release
and understand what we are ALSO releasing into maven.

                
> maven artifacts should be equivalent to binary packaging
> --------------------------------------------------------
>
>                 Key: SOLR-3405
>                 URL: https://issues.apache.org/jira/browse/SOLR-3405
>             Project: Solr
>          Issue Type: Task
>          Components: Build
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>
> Lets take the commons-csv scenario: 
> * apache-solr-3.5.0 binary distribution contains no actual commons-csv.jar 
> anywhere,
>   in fact it contains no third party jars (the stuff present in solr/lib) at 
> all.
> * binary distribution contains only the jars necessary for *solrj* and 
> *contrib plugins*, and a solr.war
> I think the maven artifacts should match whats in the binary release (no 
> third party jars 
> inside the .war are "exposed", we just publish the .war itself). This exposes 
> a lot less surface area.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to