[ 
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Male updated LUCENE-2510:
-------------------------------

    Attachment: LUCENE-2510-parent-classes.patch

Patch which moves the Factory interfaces and base implementations (and some 
associated classes).  

Command:

{noformat}
svn mkdir lucene/analysis/common/src/java/org/apache/lucene/analysis/factory
svn mv solr/core/src/java/org/apache/solr/analysis/BaseCharFilterFactory.java 
lucene/analysis/common/src/java/org/apache/lucene/analysis/factory/BaseCharFilterFactory.java
svn mv solr/core/src/java/org/apache/solr/analysis/BaseTokenFilterFactory.java 
lucene/analysis/common/src/java/org/apache/lucene/analysis/factory/BaseTokenFilterFactory.java
svn mv solr/core/src/java/org/apache/solr/analysis/BaseTokenizerFactory.java 
lucene/analysis/common/src/java/org/apache/lucene/analysis/factory/BaseTokenizerFactory.java
svn mv solr/core/src/java/org/apache/solr/analysis/BaseTokenStreamFactory.java 
lucene/analysis/common/src/java/org/apache/lucene/analysis/factory/BaseTokenStreamFactory.java
svn mv solr/core/src/java/org/apache/solr/analysis/CharFilterFactory.java 
lucene/analysis/common/src/java/org/apache/lucene/analysis/factory/CharFilterFactory.java
svn mv solr/core/src/java/org/apache/solr/analysis/MultiTermAwareComponent.java 
lucene/analysis/common/src/java/org/apache/lucene/analysis/factory/MultiTermAwareComponent.java
svn mv solr/core/src/java/org/apache/solr/analysis/TokenFilterFactory.java 
lucene/analysis/common/src/java/org/apache/lucene/analysis/factory/TokenFilterFactory.java
svn mv solr/core/src/java/org/apache/solr/analysis/TokenizerFactory.java 
lucene/analysis/common/src/java/org/apache/lucene/analysis/factory/TokenizerFactory.java
svn mv solr/core/src/java/org/apache/solr/analysis/InitializationException.java 
lucene/analysis/common/src/java/org/apache/lucene/analysis/factory/InitializationException.java
{noformat}

A big TODO after all this moving is to collapse the base implementations into a 
single {{BaseAnalysisFactory}} class and get rid of FactoryUtils.

Tests pass.
                
> migrate solr analysis factories to analyzers module
> ---------------------------------------------------
>
>                 Key: LUCENE-2510
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2510
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: modules/analysis
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-2510-parent-classes.patch, LUCENE-2510.patch, 
> LUCENE-2510.patch, LUCENE-2510.patch
>
>
> In LUCENE-2413 all TokenStreams were consolidated into the analyzers module.
> This is a good step, but I think the next step is to put the Solr factories 
> into the analyzers module, too.
> This would make analyzers artifacts plugins to both lucene and solr, with 
> benefits such as:
> * users could use the old analyzers module with solr, too. This is a good 
> step to use real library versions instead of Version for backwards compat.
> * analyzers modules such as smartcn and icu, that aren't currently available 
> to solr users due to large file sizes or dependencies, would be simple 
> optional plugins to solr and easily available to users that want them.
> Rough sketch in this thread: 
> http://www.lucidimagination.com/search/document/3465a0e55ba94d58/solr_and_analyzers_module
> Practically, I havent looked much and don't really have a plan for how this 
> will work yet, so ideas are very welcome.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to