[ 
https://issues.apache.org/jira/browse/LUCENE-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265964#comment-13265964
 ] 

Michael McCandless commented on LUCENE-3830:
--------------------------------------------

bq. Just laughing a little bit to stumble on this:

Only 23 pages!

bq. Javadoc is probably wrong (sequence of bytes?).

Thanks Dawid, I'll fix.

bq. I'd probably implement it based on the stack of currently "active" tokens 
moving through the fst – this way you know when you have a greedy first longest 
match simply by looking at the set of active tokens when a match fires instead 
of restarting from each position.

Hmm I don't quite understand ... can you describe more?

If there's something simple in between what MappingCharFilter (and my patch) 
does today ("restart on each position"), and the 23 page paper, that would be 
nice :)

                
> MappingCharFilter could be improved by switching to an FST.
> -----------------------------------------------------------
>
>                 Key: LUCENE-3830
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3830
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Dawid Weiss
>            Assignee: Michael McCandless
>            Priority: Minor
>              Labels: gsoc2012, lucene-gsoc-12
>             Fix For: 4.0
>
>         Attachments: LUCENE-3830.patch
>
>
> MappingCharFilter stores an overly complex tree-like structure for matching 
> input patterns. The input is a union of fixed strings mapped to a set of 
> fixed strings; an fst matcher would be ideal here and provide both memory and 
> speed improvement I bet.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to