[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269598#comment-13269598
]
Chris Male commented on LUCENE-2510:
------------------------------------
{quote}
I think we should revisit this. I don't like placing this into the analyzers
module when not many factories actually use it, instead a lot of unrelated code
in solr actually uses it. I think this could cause a mess.
{quote}
I agree. It feels messy where it is currently.
{quote}
For example, if we use NamedSPILoader instead to allow components such as
factories to be found by name, then we can support
"solr.WhitespaceTokenizerFactory" because
TokenizerFactory.forName("WhitespaceTokenizerFactory") works.
{quote}
I don't really know much about NamedSPILoader but I think what you're
suggesting. How would we support Factories loading unrelated classes like they
can through ResourceLoader now? Assume they're on the classpath and use
Class.forName?
> migrate solr analysis factories to analyzers module
> ---------------------------------------------------
>
> Key: LUCENE-2510
> URL: https://issues.apache.org/jira/browse/LUCENE-2510
> Project: Lucene - Java
> Issue Type: Task
> Components: modules/analysis
> Affects Versions: 4.0
> Reporter: Robert Muir
> Fix For: 4.0
>
> Attachments: LUCENE-2510-parent-classes.patch,
> LUCENE-2510-parent-classes.patch, LUCENE-2510-parent-classes.patch,
> LUCENE-2510-resourceloader-bw.patch, LUCENE-2510.patch, LUCENE-2510.patch,
> LUCENE-2510.patch
>
>
> In LUCENE-2413 all TokenStreams were consolidated into the analyzers module.
> This is a good step, but I think the next step is to put the Solr factories
> into the analyzers module, too.
> This would make analyzers artifacts plugins to both lucene and solr, with
> benefits such as:
> * users could use the old analyzers module with solr, too. This is a good
> step to use real library versions instead of Version for backwards compat.
> * analyzers modules such as smartcn and icu, that aren't currently available
> to solr users due to large file sizes or dependencies, would be simple
> optional plugins to solr and easily available to users that want them.
> Rough sketch in this thread:
> http://www.lucidimagination.com/search/document/3465a0e55ba94d58/solr_and_analyzers_module
> Practically, I havent looked much and don't really have a plan for how this
> will work yet, so ideas are very welcome.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
