Chris Male created LUCENE-4048:
----------------------------------

             Summary: Move getLines out of ResourceLoader and require Charset
                 Key: LUCENE-4048
                 URL: https://issues.apache.org/jira/browse/LUCENE-4048
             Project: Lucene - Java
          Issue Type: Improvement
          Components: modules/analysis
            Reporter: Chris Male


{{ResourceLoader.getLines()}} is only used by analysis factories.  
{{SolrResourceLoader}}'s implementation does the job well and it's unlikely 
that another {{ResourceLoader}} implementation would handle it differently.

We should extract the {{getLines()}} method out to {{AbstractAnalysisFactory}} 
so it can be used by the factories.  Additionally we shouldn't assume the files 
are encoded in UTF-8, instead we should allow a Charset to be specified.

This would take us one step closer to reducing the {{ResourceLoader}} interface 
just to what it says, a loader of resources.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to