[ 
https://issues.apache.org/jira/browse/SOLR-3471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279733#comment-13279733
 ] 

Uwe Schindler commented on SOLR-3471:
-------------------------------------

Hoss wrote on dev list:

{quote}

: From:
: 
http://jenkins.sd-datasolutions.de/job/Windows-Lucene-Solr-tests-only-trunk/63/testReport/junit/org.apache.solr.update/SoftAutoCommitTest/testSoftAndHardCommitMaxTimeMixedAdds/
: 
: soft529 occured too fast: 1337365513160 + 500 !<= 1337365513589
: 
: Is 'too fast' really an error?
: 
: I thought the contract with commit times is that it happens within
: some amount of time "too fast" would be *before* we issue a
: request....  or am I missing something?

I believe that my intent with that assert is that since this is a single 
threaded test, nothing else should be triggering any commits ... so if we see a 
softCommit happening before the softCommitWaitMillis has elapsed, it must have 
been triggered by something else, but there isn't suppose to be anything else 
that could have caused it, so it must be a bug.

That said: i will not cry it you want to remove the assert.

I wrote that test in a paranoia induced psychosis brought on by trying to 
recreate the functional logic of the previous auto commit test(s) while 
simultenously trying to avoid all of hte absurd assumptions that plauged those 
test(s).


-Hoss
{quote}
                
> Tests not working on Windows
> ----------------------------
>
>                 Key: SOLR-3471
>                 URL: https://issues.apache.org/jira/browse/SOLR-3471
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Uwe Schindler
>            Priority: Blocker
>             Fix For: 4.0
>
>
> The following tests are failing on Windows quite often:
> - SoftAutoCommitTest (all tests): There seem to be wrong assumes - I dont 
> like the test "testing" how fast something is (there are slow machines or 
> machines with <= 2 cores)
> - TestSolrDeletionPolicy1.testCommitAge() - also maybe timing issue. 
> Otherwise I think the custom Solr DeletionPolicy is not respecting the fact 
> that Windows cannot delete open files
> I annotate the tests with an assume disabling Windows until this is fixed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to